[
https://jira.codehaus.org/browse/SUREFIRE-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322467#comment-322467
]
Kristian Rosenvold commented on SUREFIRE-833:
---------------------------------------------
You may very well be right; I just seem to recall a quite recent discussion on
the Junit mailing list about extending the scope of junit to be more involved
in filtering.
I'm not saying I don't want this patch as such; I just want to discuss it a
little in context of junit first. The thing about our current filtering logic
is that it's probably not very optimal (at least I tend to think it's a mess
every time I try to change it - I can say that safely since I wrote most of it
;) The concerns in the discussion on the junit list was that all the runners
implement slightly different scanning logic, and some of it should probably be
moved out of the various runners and into junit.
I think the patch is cool; I want this as much as you do. Let's just run it
past the junit folks first.
> Support for annotated JUnit @Category
> -------------------------------------
>
> Key: SUREFIRE-833
> URL: https://jira.codehaus.org/browse/SUREFIRE-833
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Junit 4.x support
> Affects Versions: 2.12
> Reporter: Jan Goyvaerts
> Fix For: 2.15
>
> Attachments: SUREFIRE-833-spraguep-2.patch,
> SUREFIRE-833-spraguep.patch
>
>
> The current implementation of Surefire seems to look for explicit @Category
> annotations in the test classes. And will only consider those. Suppose I'd
> like to add a more concise annotation for this:
> @Category(IntegrationTests.class) <== JUnit @Category
> @Target({ElementType.TYPE})
> @Retention(RetentionPolicy.RUNTIME)
> @Documented
> public @interface IntegrationTest {}
> Annotating my test class with @IntegrationTest does not work. Although I
> think it looks much better than repeating everywhere in my code
> "@Category(com.foo.bar.IntegrationTests.class)". For which I add an
> additional dependency in the interface class btw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
