[ 
https://jira.codehaus.org/browse/SUREFIRE-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322466#comment-322466
 ] 

Paul Sprague commented on SUREFIRE-833:
---------------------------------------

I don't see why or how this functionality would be part of JUnit. This patch is 
only concerned with selecting a set of test classes to run. JUnit provides APIs 
for this to be done; i.e. Runners and Filters. Surefire is already doing 
filtering based on the filename and JUnit category annotations so why is this 
any different?

If you don't want this code in surefire what about adding an feature to allow 
for the inject of custom junit Filters into the classpath scanning process?
                
> Support for annotated JUnit @Category
> -------------------------------------
>
>                 Key: SUREFIRE-833
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-833
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Junit 4.x support
>    Affects Versions: 2.12
>            Reporter: Jan Goyvaerts
>             Fix For: 2.15
>
>         Attachments: SUREFIRE-833-spraguep-2.patch, 
> SUREFIRE-833-spraguep.patch
>
>
> The current implementation of Surefire seems to look for explicit @Category 
> annotations in the test classes. And will only consider those. Suppose I'd 
> like to add a more concise annotation for this:
> @Category(IntegrationTests.class) <== JUnit @Category
> @Target({ElementType.TYPE})
> @Retention(RetentionPolicy.RUNTIME)
> @Documented
> public @interface IntegrationTest {}
> Annotating my test class with @IntegrationTest does not work. Although I 
> think it looks much better than repeating everywhere in my code 
> "@Category(com.foo.bar.IntegrationTests.class)". For which I add an 
> additional dependency in the interface class btw.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to