[
https://jira.codehaus.org/browse/SUREFIRE-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317037#comment-317037
]
Kristian Rosenvold edited comment on SUREFIRE-946 at 1/9/13 11:44 AM:
----------------------------------------------------------------------
I have looked at the patch, and applied it to trunk in
e54dbd810f62fe723800f11279b881bff244b707
@andreas: I have a couple of minor considerations I'd like your input on;
TestProvidingInputStream has synchronized read method. As far as I can tell the
use of this class is confined to a single thread? If this is not the case, then
"close" must be synchronized (or "closed" volatile), since there is mismatched
synchronization on this variable in the class. (Both reads and writes need to
be synchronized for correctness). BUt it seems like this class is NotThreadSafe
?
In forkedBooter, I'm not sure I understand the added value provided by the
ForkingRunListener.BOOTERCODE_CRASH, since by my meagre understanding, anything
that is not BOOTERCODE_BYE implies a crash ?
(Which was the existing logic)
was (Author: krosenvold):
I have looked at the patch, and applied it to trunk in
e54dbd810f62fe723800f11279b881bff244b707
@andread: I have a couple of minor considerations I'd like your input on;
TestProvidingInputStream has synchronized read method. As far as I can tell the
use of this class is confined to a single thread? If this is not the case, then
"close" must be synchronized (or "closed" volatile), since there is mismatched
synchronization on this variable in the class. (Both reads and writes need to
be synchronized for correctness). BUt it seems like this class is NotThreadSafe
?
In forkedBooter, I'm not sure I understand the added value provided by the
ForkingRunListener.BOOTERCODE_CRASH, since by my meagre understanding, anything
that is not BOOTERCODE_BYE implies a crash ?
(Which was the existing logic)
> Maven hangs on SIGTERM when using Surefire forking
> (CommandLineUtils.ProcessHook)
> ---------------------------------------------------------------------------------
>
> Key: SUREFIRE-946
> URL: https://jira.codehaus.org/browse/SUREFIRE-946
> Project: Maven Surefire
> Issue Type: Bug
> Affects Versions: 2.13
> Reporter: Jesse Glick
> Fix For: 2.14
>
> Attachments: stack.txt, SUREFIRE-946.patch
>
>
> Java 7u7, Surefire with JUnit {{forkMode="perthread"}} + {{threadCount="1"}}
> + {{reuseForks="true"}}. After pressing Ctrl-C to stop the Maven test run,
> the process hangs and must be killed with SIGKILL. From the thread dump,
> {{CommandLineUtils.ProcessHook}} and {{StreamFeeder}} look responsible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
