[ 
https://jira.codehaus.org/browse/SUREFIRE-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=315312#comment-315312
 ] 

Andreas Gudian commented on SUREFIRE-934:
-----------------------------------------

OK, I pulled from apache.org and created the patch based on that. So the 
pull-request on github also contains the commit for SUREFIRE-933, but I guess 
that's no problem for git. :)
-Pembedded worked quite fine, definetly faster (mvn 3.0.4). On the first run, I 
had a failure in Surefire570MultipleReportDirectoriesIT - a second try was 
successful. I'll give it some more spins with and without -Pembedded to see if 
I can reproduce that.
                
> Remove getLocatedClasses() and size() from TestsToRun
> -----------------------------------------------------
>
>                 Key: SUREFIRE-934
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-934
>             Project: Maven Surefire
>          Issue Type: Task
>          Components: process forking
>    Affects Versions: 2.13
>            Reporter: Andreas Gudian
>            Priority: Minor
>
> In order to avoid any further confusion with 
> {{TestsToRun.getLocatedClasses()}} and {{TestsToRun.size()}} (as in 
> SUREFIRE-933), I propose to remove these methods completely.
> Basically, these methods are used in the TestNG provider at some limited 
> places, and in {{DefaultRunOrderCalculator}} during the scan for tests (in 
> the main surefire process).
> If you have any objections, please close this issue. Otherwise, I will just 
> do it and send a pull request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to