[ 
https://jira.codehaus.org/browse/SUREFIRE-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=315285#comment-315285
 ] 

Kristian Rosenvold commented on SUREFIRE-934:
---------------------------------------------

I love cleaning code ;) As long as the IT's pass we're fine.

Do check out the -Pembedded I just added to surefire btw. Make sure you have 
enough permgen until we release 3.1 though
                
> Remove getLocatedClasses() and size() from TestsToRun
> -----------------------------------------------------
>
>                 Key: SUREFIRE-934
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-934
>             Project: Maven Surefire
>          Issue Type: Task
>          Components: process forking
>    Affects Versions: 2.13
>            Reporter: Andreas Gudian
>            Priority: Minor
>
> In order to avoid any further confusion with 
> {{TestsToRun.getLocatedClasses()}} and {{TestsToRun.size()}} (as in 
> SUREFIRE-933), I propose to remove these methods completely.
> Basically, these methods are used in the TestNG provider at some limited 
> places, and in {{DefaultRunOrderCalculator}} during the scan for tests (in 
> the main surefire process).
> If you have any objections, please close this issue. Otherwise, I will just 
> do it and send a pull request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to