[
https://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=309393#comment-309393
]
Dennis Lundberg commented on MWAR-164:
--------------------------------------
I have committed a fix for this in
http://svn.apache.org/viewvc?view=revision&revision=1388368 complete with an
IT. The default encoding used is project.build.sourceEncoding, as suggested.
I went the more difficult path and did not set the configured encoding for xml
files. Intead for xml files (currently files ending in ".xml") the encoding is
read from the files themselves. This means that you can have a mix of encodings
in your resource files. The IT has a properties file encoded in ISO-8859-1 and
an xml file encoded in UTF-8 which is also specified in the files xml header.
Apart from the IT I've successfully tried this on several local projects that
suffer from this bug.
I have not yet deployed a new SNAPSHOT, but will do so later today. Please help
test this.
Also I want to add some documentation for this, apart from the parameter
documentation that went in with this commit, before I close the issue.
> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
> Key: MWAR-164
> URL: https://jira.codehaus.org/browse/MWAR-164
> Project: Maven 2.x WAR Plugin
> Issue Type: Improvement
> Components: filtering
> Affects Versions: 2.1-alpha-1
> Reporter: kai lilleby
> Assignee: Dennis Lundberg
> Fix For: 2.3
>
> Attachments: MWAR-164-maven-war-plugin.patch
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
