[ 
https://jira.codehaus.org/browse/MRELEASE-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=293731#comment-293731
 ] 

Robert Scholte commented on MRELEASE-239:
-----------------------------------------

I think we need to add the tab-character too. 
Also: the {{InvokerMavenExecutor}} still splits on spaces only. This is valid 
according to the javadoc, which states that {{goals}} is a space-delimited 
String. Maybe it is better add an overloaded method to the 
{{AbstractExecutor}}, which already translates the String to an array of goals, 
so there's no doubt about its content.
                
> release:perform and release:prepare should accept multi-line 
> goals/preparationGoals configurations
> --------------------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-239
>                 URL: https://jira.codehaus.org/browse/MRELEASE-239
>             Project: Maven 2.x Release Plugin
>          Issue Type: Improvement
>          Components: prepare
>    Affects Versions: 2.0-beta-6
>            Reporter: Steve Rowe
>            Assignee: Stephen Connolly
>            Priority: Minor
>             Fix For: 2.2.1
>
>         Attachments: ForkedMavenExecutor.patch
>
>
> When I specify a list of goals in my POM that span multiple lines (see an 
> example below), only those goals before the newline are executed when I run 
> "mvn release:perform". 
> I have only noticed this for release:perform, but given what the code looks 
> like, I assume it's an issue for release:prepare too.
> This is a minor problem, but an irritating one, because release:peform claims 
> to successfully complete without actually executing all specified goals.
> I attach a patch to ForkedMavenExecutor.java that splits the goals list on 
> newlines and carriage returns, in addition to the comma and space split 
> characters that were there already.
> Here's an example configuration that will trigger the problem:
>       <plugin>
>         <artifactId>maven-release-plugin</artifactId>
>         <configuration>
>           ...
>           <goals>
>             package group:first-goal group:second-goal group:third-goal
>             site-deploy changes:announcement-generate 
> changes:announcement-mail
>           </goals>
>         </configuration>
>       </plugin>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to