[
https://jira.codehaus.org/browse/SCM-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=293245#comment-293245
]
Mirko Friedenhagen edited comment on SCM-667 at 3/2/12 3:42 PM:
----------------------------------------------------------------
Hello Robert,
* I agree using {{String}} compare feels like a hack. On the other side,
rethrowing the {{IOException}} as {{IllegalArgumentException}} is IMO a clean
solution in this case, I do not think it should come to this.
* Using {{canonicalPath}} is platform agnostic as well, it will deliver a Linux
path on Linux, a MacOSX path on MacOSX and a Windows path on Windows.
* Tests are running successfully on Mac OS X (you have to trust me on this one
:-)) and on Linux (http://huschteguzzel.de/hudson/job/maven-scm/4/) as well.
* I use a fork BTW (https://github.com/mfriedenhagen/maven-scm), I will give it
a shot to get a working solution using {{URI}} or {{isAncestor}} this weekend.
* BTW: the {{URI}} solution has to use {{canonicalFile}} nonetheless, so the
{{IOException}} has to be handled anyway.
Regards
Mirko
was (Author: mfriedenhagen):
Hello Robert,
* I agree using {{String}} compare feels like a hack. On the other side,
rethrowing the {{IOException}} as {{IllegalArgumentException}} is IMO a clean
solution in this case, I do not think it should come to this.
* Using {{canonicalPath}} is platform agnostic as well, it will deliver a Linux
path on Linux, a MacOSX path on MacOSX and a Windows path on Windows.
* Tests are running successfully on Mac OS X (you have to trust me on this one
:-)) and on Linux (http://huschteguzzel.de/hudson/job/maven-scm/4/) as well.
* I use a fork BTW (https://github.com/mfriedenhagen/maven-scm), I will give it
a shot to get a working solution using {{URI}} this weekend.
Regards
Mirko
> mvn release:prepare fails for hierarchical multi-module project on Windows 7
> using msysgit with "is outside repository"
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: SCM-667
> URL: https://jira.codehaus.org/browse/SCM-667
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-git
> Affects Versions: 1.6
> Environment: c:\ws\testlink-junit2>mvn --version
> Apache Maven 3.0.4 (r1232337; 2012-01-17 09:44:56+0100)
> Maven home: c:\tools\apache-maven-3\bin\..
> Java version: 1.6.0_29, vendor: Sun Microsystems Inc.
> Java home: C:\Program Files\Java\jdk1.6.0_29\jre
> Default locale: de_DE, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> c:\ws\testlink-junit2>git --version
> git version 1.7.8.msysgit.1
> c:\ws\testlink-junit2>git remote -v
> origin git://github.com/1and1/testlink-junit.git (fetch)
> origin git://github.com/1and1/testlink-junit.git (push)
> Reporter: Mirko Friedenhagen
> Priority: Critical
> Attachments: SCM-667.patch
>
>
> Steps to reproduce (provided Maven, Java and Git are installed on your
> Windows-Machine):
> # Run: {code}
> git clone git://github.com/1and1/testlink-junit.git testlink-junit2
> cd testlink-junit2
> mvn -DpushChanges=false -e -B release:prepare
> {code}
> Console output: {code}
> [INFO] Checking in modified POMs...
> [INFO] Executing: cmd.exe /X /C "git add -- pom.xml
> C:\ws\testlink-junit2\tljunit-surefire\pom.xml
> C:\ws\testlink-junit2\tljunit-eclipse\pom.xml"
> [INFO] Working directory: c:\ws\testlink-junit2
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] tljunit parent .................................... FAILURE [22.561s]
> [INFO] tljunit surefire RunListeners ..................... SKIPPED
> [INFO] tljunit sample project for running tests from eclipse. SKIPPED
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 24.879s
> [INFO] Finished at: Wed Feb 29 17:58:15 CET 2012
> [INFO] Final Memory: 13M/177M
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:2.2.2:prepare (default-cli) on
> project tljunit-parent: Unable to commit files
> [ERROR] Provider message:
> [ERROR] The git-add command failed.
> [ERROR] Command output:
> [ERROR] fatal: 'C:\ws\testlink-junit2\tljunit-surefire\pom.xml' is outside
> repository
> [ERROR] -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-release-plugin:2.2.2:prepare
> (default-cli) on project tljunit-parent: Unable to commit files
> Provider message:
> The git-add command failed.
> Command output:
> fatal: 'C:\ws\testlink-junit2\tljunit-surefire\pom.xml' is outside repository
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.MojoFailureException: Unable to commit
> files
> Provider message:
> The git-add command failed.
> Command output:
> fatal: 'C:\ws\testlink-junit2\tljunit-surefire\pom.xml' is outside repository
> at
> org.apache.maven.plugins.release.PrepareReleaseMojo.prepareRelease(PrepareReleaseMojo.java:310)
> at
> org.apache.maven.plugins.release.PrepareReleaseMojo.execute(PrepareReleaseMojo.java:258)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> ... 19 more
> Caused by: org.apache.maven.shared.release.scm.ReleaseScmCommandException:
> Unable to commit files
> Provider message:
> The git-add command failed.
> Command output:
> fatal: 'C:\ws\testlink-junit2\tljunit-surefire\pom.xml' is outside repository
> at
> org.apache.maven.shared.release.phase.AbstractScmCommitPhase.checkin(AbstractScmCommitPhase.java:168)
> at
> org.apache.maven.shared.release.phase.AbstractScmCommitPhase.performCheckins(AbstractScmCommitPhase.java:148)
> at
> org.apache.maven.shared.release.phase.ScmCommitPreparationPhase.runLogic(ScmCommitPreparationPhase.java:75)
> at
> org.apache.maven.shared.release.phase.AbstractScmCommitPhase.execute(AbstractScmCommitPhase.java:79)
> at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:206)
> at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:142)
> at
> org.apache.maven.shared.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:104)
> at
> org.apache.maven.plugins.release.PrepareReleaseMojo.prepareRelease(PrepareReleaseMojo.java:302)
> ... 22 more
> [ERROR]
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
