[ https://jira.codehaus.org/browse/SUREFIRE-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=286046#comment-286046 ]
Kristian Rosenvold commented on SUREFIRE-806: --------------------------------------------- Sounds like a good plan. I'll take a look at the code wrt item 2 since it's not at the top of my head. There should be unit tests to expand covering most of these functionality changes. The integration test coverage is excellent (there is a -Pparallel profile for the IT's btw), and at least one IT should be added; if you don't break any IT's your change is good ;) The thing is, if I understand this correctly, it's not just "ignoreIncludesOnSingleTest", because setting it to false also implies setting failIfNoTests=false, so maybe something like "testOnlyIfApplicable" that defaults to false. Bah. > Make ignoring of <includes> and <excludes> on -Dtest=... optional (for > multiple Surefire executions) > ---------------------------------------------------------------------------------------------------- > > Key: SUREFIRE-806 > URL: https://jira.codehaus.org/browse/SUREFIRE-806 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Surefire Plugin > Affects Versions: 2.11 > Reporter: Ondrej Zizka > Assignee: John Casey > Attachments: surefire-806-testParam-hits-all-executions.zip > > > Let's have a single module with multiple Surefire executions (e.g. with > different Arquillian configs) > Tests are divided to run in either one, using <includes> and <excludes>. > Then, if you use -Dtest=..., the specified test(s) is run twice - once for > each execution (and usually fails in one of them in our scenario). > My suggestion is to introduce a Surefire config property which would make > this behavior optional: > {code} > <configuration> > <ignoreIncludesOnSingleTest>false</ignoreIncludesOnSingleTest> > </configuration> > {code} > This would cause Surefire to run the intersection of the two sets - > one created by the mask from -Dtest=..., > second created by the includes and excludes of the respective execution. > Current description from > http://maven.apache.org/plugins/maven-surefire-plugin/test-mojo.html : > {quote} > Specify this parameter to run individual tests by file name, overriding the > includes/excludes parameters. Each pattern you specify here will be used to > create an include pattern formatted like **/${test}.java, so you can just > type "-Dtest=MyTest" to run a single test called "foo/MyTest.java". > This parameter overrides the includes/excludes parameters, and the TestNG > suiteXmlFiles parameter. > {quote} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira