[ 
https://jira.codehaus.org/browse/MGPG-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=276633#comment-276633
 ] 

Stephen Connolly commented on MGPG-34:
--------------------------------------

Would need to see integration tests that verify that this patch does not affect 
builds of projects with both packaging pom and packaging jar.

And would also need to see integration tests that verify correct behaviour when 
using the maven-shade-plugin on a jar project and having shade replace the pom 
file with the dependency reduced pom file.

I suspect that the real cause is that whatever custom actions you are doing to 
create these custom pom files is failing to register the pom file change with 
the model the way that m-shade-p does, i.e. 
http://maven.apache.org/plugins/maven-shade-plugin/xref/org/apache/maven/plugins/shade/mojo/ShadeMojo.html#851
 Note however that shade is doing a lot more crazy stuff so it is really only 
the line 851 that is what is required (much like creating custom artifacts 
requires they be attached to the reactor)

> Allow to define an alternative pomFile when sign (gpg:sign) the project 
> artifact
> --------------------------------------------------------------------------------
>
>                 Key: MGPG-34
>                 URL: https://jira.codehaus.org/browse/MGPG-34
>             Project: Maven 2.x GPG Plugin
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Laszlo Hordos
>              Labels: scrub-review-started
>         Attachments: maven-gpg-plugin.patch
>
>
> This small modification allow to specify an alternative pomFile to sign 
> instead of the default project file. It's very useful when a custom pom file 
> has been generated during the build process. I'm using a complex build 
> configuration for a framework where I need to create custom pom files. I'm 
> able create a release from my CI and publish it to the central repository the 
> gpg:sign signs the wrong pom file.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to