[
http://jira.codehaus.org/browse/MCHANGES-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=270211#comment-270211
]
Dennis Lundberg commented on MCHANGES-259:
------------------------------------------
Benson,
Some thoughts and questions after a brief look at your patch.
* Lots of good stuff in there with the abstract class and all
* I haven't worked with enums before. What data is stored in an "instance" of
IssueType?
* Is DefaultIssueManagmentSystem really needed? Or should it be renamed to
JIRAIssueManagementSystem
* Was there a particular reason to change the logic in AnnouncementMojo? The
reason I ask is that I envision changes.xml to be just another IMS in the
future, and the changes to the logic seems to go against that. I.e it hard
codes the changes + 1 that we currently have, making it harder to change that
going forward.
A couple of more things I'd like to do:
* Add an interface IssueManagementSystem and use that wherever possible in
place of AbstractIssueManagementSystem
* Add a constant in IssueAdapter:
final String UNKNOWN_TYPE = "";
> Create modularity for supporting multiple issue management systems
> ------------------------------------------------------------------
>
> Key: MCHANGES-259
> URL: http://jira.codehaus.org/browse/MCHANGES-259
> Project: Maven 2.x Changes Plugin
> Issue Type: Improvement
> Components: other issue-trackers
> Affects Versions: 2.5
> Reporter: Benson Margulies
> Assignee: Benson Margulies
> Attachments: MCHANGES-259.patch
>
>
> In discussion of MCHANGES-245, Dennis notes the need for some global
> modularity for capturing the behavior of the different issue management
> systems. I'm creating this JIRA as a hat-rack to hang this work off of.
> My plan is to start by creating something very simple in the way of an
> abstract class, which can be elaborated as we go.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
