[ 
http://jira.codehaus.org/browse/DOXIA-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=268686#action_268686
 ] 

Lukas Theussl commented on DOXIA-426:
-------------------------------------

Patch applied in [r1128181|http://svn.apache.org/viewvc?rev=1128181&view=rev], 
thanks! Some remarks:

* I was stuck first with some weird plexus error until I realized that you had 
removed the text from MarkdownSink but not deleted the file
* I also removed MarkdownParseException, as it only delegated to ParseException
* please don't change the formatting, import order etc.

Two more requests:

* the test resource file test.md should contain a complete document with all 
supported markup, a la test.apt (it doesn't actually have to be tested, just to 
check that the parser doesn't choke on anything).
* It would be nice to have a rudimentary site with intro and links to some 
external resources.

Can you supply that? Otherwise looks good IMO.

> Markdown module
> ---------------
>
>                 Key: DOXIA-426
>                 URL: http://jira.codehaus.org/browse/DOXIA-426
>             Project: Maven Doxia
>          Issue Type: New Feature
>          Components: Modules
>    Affects Versions: 1.3
>            Reporter: Julien Nicoulaud
>         Attachments: doxia-module-markdown-2.patch, 
> doxia-module-markdown.patch
>
>
> [Markdown|http://en.wikipedia.org/wiki/Markdown] is a widespread Markup 
> language. It would be nice if there was a Doxia module for Markdown.
> Here is a proposed simple implementation that defers all the parsing and 
> rendering to [PegDown|http://pegdown.org] (Apache License V2), which is the 
> most reliable Java library for Markdown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to