[
http://jira.codehaus.org/browse/SUREFIRE-695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Rosenvold closed SUREFIRE-695.
---------------------------------------
Resolution: Fixed
Fix Version/s: 2.7.3
Assignee: Kristian Rosenvold
Applied unchanged in r1069073. That's a good patch that really improves
quality, Thanks!
> Avoid duplicate code in SurefirePlugin and IntegrationTestMojo
> --------------------------------------------------------------
>
> Key: SUREFIRE-695
> URL: http://jira.codehaus.org/browse/SUREFIRE-695
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
> Affects Versions: 2.7
> Reporter: Stefan Birkner
> Assignee: Kristian Rosenvold
> Fix For: 2.7.3
>
> Attachments: SUREFIRE-verifyParameters.patch
>
>
> The methods verifyParameters() and execute() have much code in common.
> Therefore I moved these parts of the code to the AbstractSurefireMojo and
> created two abstract methods executeAfterPreconditionsChecked() and
> isSkipExecution(). For the sake of not changing the API, I didn't change the
> visibility of verifyParameters() from public to private.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
