[
http://jira.codehaus.org/browse/DOXIASITETOOLS-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=245966#action_245966
]
Dennis Lundberg commented on DOXIASITETOOLS-40:
-----------------------------------------------
I had a look at your patch and have a question.
You have added this code:
{code}
public void addSiteLocales(List locales) {
siteLocales.addAll(locales);
}
{code}
Wouldn't it be better to have this instead?
{code}
public void setSiteLocales(List locales) {
siteLocales = Collections.unmodifiableList( locales );
}
{code}
When you work on implementing the "locale switcher", keep in mind that it's a
bad idea to use images of flags to represent languages. You mentioned adding
images in your previous comment.
See http://www.w3.org/TR/i18n-html-tech-lang/#ri20040808.173208643
> List of site locales should be available in the rendering context.
> ------------------------------------------------------------------
>
> Key: DOXIASITETOOLS-40
> URL: http://jira.codehaus.org/browse/DOXIASITETOOLS-40
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
> Affects Versions: 1.1.4
> Reporter: Yevgeny Nyden
> Attachments: siteLocalesChange-sitetools.diff
>
>
> Attached is a small improvement that adds a list of available site locales to
> the site rendering context. This would make a site template be "aware" of
> other locales available for the site and make it possible to implement a
> locale switching option.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
