[
http://jira.codehaus.org/browse/DOXIA-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=235673#action_235673
]
Dennis Lundberg commented on DOXIA-408:
---------------------------------------
The failures are in XmlWriterXdocSinkTest, not XdocSinkTest. See the attached
Surefire report.
The methods getListBlock(), getNumberedListBlock(), getDefinitionListBlock()
and getTableBlock() all have XmlUtil.DEFAULT_LINE_SEPARATOR in them, which is
what I think is the source of problem. These methods represent the expected
results and the actual results come from the sink that is created in
{code:java}
protected Sink createSink( Writer writer )
{
return new XmlWriterXdocSink( new PrettyPrintXMLWriter( writer ) );
}
{code}
The sink uses a pretty printer so I guess that it differs in that is deemed
pretty compared to the LINE_SEPARATORs used in the methods above.
It'd probably be best if we could stop pretty printing in the tests.
> Test failures on Windows
> ------------------------
>
> Key: DOXIA-408
> URL: http://jira.codehaus.org/browse/DOXIA-408
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Xdoc
> Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200)
> Java version: 1.5.0_22
> Java home: C:\Program\Java\jdk1.5.0_22\jre
> Default locale: sv_SE, platform encoding: Cp1252
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> Reporter: Dennis Lundberg
> Attachments:
> org.apache.maven.doxia.module.xdoc.XmlWriterXdocSinkTest.txt
>
>
> mvn test in the xdoc module of the current trunk produces this output
> {noformat}
> ...
> Failed tests:
> testList(org.apache.maven.doxia.module.xdoc.XmlWriterXdocSinkTest)
> testNumberedList(org.apache.maven.doxia.module.xdoc.XmlWriterXdocSinkTest)
> testDefinitionList(org.apache.maven.doxia.module.xdoc.XmlWriterXdocSinkTest)
> testTable(org.apache.maven.doxia.module.xdoc.XmlWriterXdocSinkTest)
> Tests run: 117, Failures: 4, Errors: 0, Skipped: 0
> ...
> {noformat}
> The failures has to do with differences in line breaks for list, ordered
> list, definition list and table. See attached Surefire report.
> The actual results have one line break *less* than expected, which is odd
> considering that Windows usually get *more* line breaks. The errors might be
> due to differences between org.codehaus.plexus.util.xml.PrettyPrintXMLWriter
> and org.codehaus.plexus.util.xml.XmlUtil.prettyFormat().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
