Allow filters to work when creating the sources jar
---------------------------------------------------
Key: MSHADE-83
URL: http://jira.codehaus.org/browse/MSHADE-83
Project: Maven 2.x Shade Plugin
Issue Type: Bug
Affects Versions: 1.3.3
Reporter: Jakob Korherr
Attachments: shade-filter-sources-test.patch,
shade-filter-sources.patch
While using the maven-shade-plugin for Apache MyFaces I ran into this error:
I use a filter to include a subset of classes from another artifact. Everything
works fine for the "binary" artifact, but when creating the -sources.jar
(createSourcesJar = true) the filter does not apply.
After some digging in the code I found out that SimpleFilter gets a Set of jar
files for which it should be applied. Here, however, only the "binary" jar file
is added and not also the -sources.jar file. Thus the canFilter() check fails
later when creating the -sources.jar via shader.shade().
The attached patch solves this problem by adding the -sources.jar to the Set of
jar files if createSourcesJar is true. I already tested it and it works just
fine. Furthermore the test-patch provides a JUnit test case for this scenario.
Thanks for looking at this,
Jakob
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
