[
http://jira.codehaus.org/browse/MNG-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=222076#action_222076
]
Niall Gallagher commented on MNG-3244:
--------------------------------------
@Steven MountJoy- I looked at that patch, and I think it would improve the
situation for some people, but for us it's not going to fix the broken handling
of our scm urls because we put our variables in the middle of the urls
unfortunately, and we put "/trunk" at the end.
@all
Perhaps looking for patterns in urls is not the way to go to decide whether or
not to apply the fixed logic.
How about we apply the fix if property
"mng-3244-append-artifactId-to-parent-urls" is set to "false" (as William
Ferguson above suggested 2.5 years ago), otherwise we apply existing behaviour?
I can't see any way that this could break existing behaviour.
> inherited site url not properly handling parameters
> ---------------------------------------------------
>
> Key: MNG-3244
> URL: http://jira.codehaus.org/browse/MNG-3244
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Inheritance and Interpolation, Sites & Reporting
> Affects Versions: 2.0.7
> Reporter: Jacob Robertson
> Assignee: Brian Fox
> Fix For: Issues to be reviewed for 3.x
>
> Attachments: fix-inherited-site-url.patch, guide-site.patch,
> mng-3244_patch.txt
>
>
> Here is the test case to reroduce this problem. Take the following two
> pom.xml files
> <?xml version="1.0" encoding="UTF-8"?>
> <project>
> <groupId>org.bar</groupId>
> <artifactId>foo</artifactId>
> <name>foo</name>
> <version>1.0-SNAPSHOT</version>
> <packaging>pom</packaging>
> <modelVersion>4.0.0</modelVersion>
> <distributionManagement>
> <site>
> <id>foo-site</id>
> <url>file://C:/Documents and
> Settings/foo/.m2/site/${project.artifactId}</url>
> </site>
> </distributionManagement>
> </project>
> <?xml version="1.0" encoding="UTF-8"?>
> <project>
> <groupId>org.bar</groupId>
> <artifactId>baz</artifactId>
> <name>baz</name>
> <version>1.0-SNAPSHOT</version>
> <packaging>pom</packaging>
> <modelVersion>4.0.0</modelVersion>
> <parent>
> <artifactId>foo</artifactId>
> <groupId>org.bar</groupId>
> <version>1.0-SNAPSHOT</version>
> </parent>
> </project>
> And run the site-deploy goal on each. What you get under the site directory
> is this
> - site
> /- foo
> ---/site docs
> /- baz
> ---/- baz (extra directory)
> --- ---/site docs
> This is the simplest test case. In the case where I have a "grandparent"
> pom, the site directory uses the grandparent/parent as the path to the site,
> and doesn't use the actual artifactId of the artifact I'm creating the site
> for.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
