[ 
http://jira.codehaus.org/browse/MNG-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=221967#action_221967
 ] 

Niall Gallagher commented on MNG-3244:
--------------------------------------

My company has a flat SVN structure, with trunk/, tags/ and branches/ folders 
in every project. e.g.

.../corporate-pom/trunk/
.......................pom.xml
................./tags/
................./branches/

.../project1/trunk/
..................pom.xml
............/tags/
............/branches/

We were hoping to factor out scm, site and nexus urls from all of our projects 
into a corporate pom. Due to this bug though, maven is appending artifactid 
again after trunk/ in inherited urls, which doesn't make sense for this 
structure. So basically this bug will prevent us from factoring out most of the 
configuration, and we'll have to copy/paste the same url template into every 
pom.

Can we consider fixing this bug for maven 2.x again?

Double slashes are usually canonicalised to single slashes - 
http://en.wikipedia.org/wiki/URL_normalization - can we therefore use the 
presence of double slash as a marker?

How about not appending the artifactid again, when the url in the parent pom 
ends with a double slash '//'?

> inherited site url not properly handling parameters
> ---------------------------------------------------
>
>                 Key: MNG-3244
>                 URL: http://jira.codehaus.org/browse/MNG-3244
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Inheritance and Interpolation, Sites & Reporting
>    Affects Versions: 2.0.7
>            Reporter: Jacob Robertson
>            Assignee: Brian Fox
>             Fix For: Issues to be reviewed for 3.x
>
>         Attachments: fix-inherited-site-url.patch, guide-site.patch, 
> mng-3244_patch.txt
>
>
> Here is the test case to reroduce this problem.  Take the following two 
> pom.xml files
> <?xml version="1.0" encoding="UTF-8"?>
> <project>
>       <groupId>org.bar</groupId>
>       <artifactId>foo</artifactId>
>       <name>foo</name>
>       <version>1.0-SNAPSHOT</version>
>       <packaging>pom</packaging>
>       <modelVersion>4.0.0</modelVersion>
>       <distributionManagement>
>               <site>
>                       <id>foo-site</id>
>                       <url>file://C:/Documents and 
> Settings/foo/.m2/site/${project.artifactId}</url>
>               </site>
>       </distributionManagement>
> </project>
> <?xml version="1.0" encoding="UTF-8"?>
> <project>
>       <groupId>org.bar</groupId>
>       <artifactId>baz</artifactId>
>       <name>baz</name>
>       <version>1.0-SNAPSHOT</version>
>       <packaging>pom</packaging>
>       <modelVersion>4.0.0</modelVersion>
>       <parent>
>               <artifactId>foo</artifactId>
>               <groupId>org.bar</groupId>
>               <version>1.0-SNAPSHOT</version>
>       </parent>
> </project>
> And run the site-deploy goal on each.  What you get under the site directory 
> is this
> - site
> /- foo
> ---/site docs
> /- baz
> ---/- baz (extra directory)
> --- ---/site docs
> This is the simplest test case.  In the case where I have a "grandparent" 
> pom, the site directory uses the grandparent/parent as the path to the site, 
> and doesn't use the actual artifactId of the artifact I'm creating the site 
> for.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to