[ 
http://jira.codehaus.org/browse/MECLIPSE-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=215481#action_215481
 ] 

Guillaume Husta commented on MECLIPSE-156:
------------------------------------------

In the last version of MECLIPSE, this still does't work.
Apparently, the last patch by Jerome Lacoste has not been applied 
(IdeUtils.java).

I've tested a little, and discovered some problems :
* the value for the property "project.build.sourceEncoding" is not taken into 
account (see upper)
* the value for encoding isn't interpolated, so if you use for example
{code:xml}
<properties>
    <project.build.sourceEncoding>${myencoding}</project.build.sourceEncoding>
</properties>
{code}
the string "${myencoding}" will be output instead of the interpolated value in 
the settings
* the settings are written in the wrong file : _org.eclipse.jdt.core.prefs_ 
instead of _org.eclipse.core.resources.prefs_ (see 
EclipseSettingsWriter.FILE_ECLIPSE_JDT_CORE_PREFS)
* if a new settings file has to be created by this Mojo, maybe should it be 
also deleted in the *eclipse:clean* goal (see EclipseCleanMojo)

> Plugin should support setting file encoding
> -------------------------------------------
>
>                 Key: MECLIPSE-156
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-156
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: New Feature
>            Reporter: Ralph Poellath
>            Assignee: nicolas de loof
>             Fix For: 2.8
>
>         Attachments: maven-eclipse-plugin-2.5.1.tar.gz, 
> MECLIPSE-156-maven-eclipse-plugin.patch, 
> MECLIPSE-156_proper_use_of_project_build_sourceEncoding.patch
>
>
> The plugin should support setting Eclipse's text file encoding on a 
> per-project basis.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to