[
http://jira.codehaus.org/browse/MECLIPSE-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197036#action_197036
]
Jerome Lacoste commented on MECLIPSE-156:
-----------------------------------------
I was reading the code to try to fix another issue and there seems to be an
issue with the latest commit
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/ide/IdeUtils.java?r1=825432&r2=826602
in particular
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/ide/IdeUtils.java?view=annotate#l166
1. the check of this value shouldn't be made in the method, but probably in
getCompilerSourceEncoding()
2. the return of getProperty() should be used.
I attach a patch that is completely untested !
> Plugin should support setting file encoding
> -------------------------------------------
>
> Key: MECLIPSE-156
> URL: http://jira.codehaus.org/browse/MECLIPSE-156
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: Ralph Poellath
> Assignee: nicolas de loof
> Fix For: 2.8
>
> Attachments: maven-eclipse-plugin-2.5.1.tar.gz,
> MECLIPSE-156-maven-eclipse-plugin.patch,
> MECLIPSE-156_proper_use_of_project_build_sourceEncoding.patch
>
>
> The plugin should support setting Eclipse's text file encoding on a
> per-project basis.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
