[
http://jira.codehaus.org/browse/MRESOURCES-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Casey closed MRESOURCES-105.
---------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.5)
2.4.1
new plexus-interpolation provides a safety net for this to keep it from blowing
up, and a small change in the resources plugin detects any null delimiters
(which is what gets passed in if you specify an invalid ${xxx} expression in a
list-style configuration parameter in Maven), and replaces them with:
{noformat}
${*}
{noformat}
This isn't precisely correct, so I'm going to file another issue to take a look
at the larger issue later.
> Custom Delimiters does not work as expected - NPE with ${*} and comments in
> property file does break replacement
> ----------------------------------------------------------------------------------------------------------------
>
> Key: MRESOURCES-105
> URL: http://jira.codehaus.org/browse/MRESOURCES-105
> Project: Maven 2.x Resources Plugin
> Issue Type: Bug
> Affects Versions: 2.4
> Environment: Ubuntu Jaunty, Sun JDK 1.6.0_16, Maven 2.2.1
> Reporter: Torsten Krah
> Assignee: Olivier Lamy
> Fix For: 2.4.1
>
> Attachments: test.tar.bz2
>
>
> Hi,
> using custom delimiters, stuff is not working as expected.
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-resources-plugin</artifactId>
> <version>2.4</version>
> <configuration>
> <useDefaultDelimiters>false</useDefaultDelimiters>
> <delimiters>
> <delimiter>$</delimiter>
> <delimiter>@</delimiter>
> <delimiter>#</delimiter>
> <delimiter>${*}</delimiter>
> </delimiters>
> <encoding>UTF-8</encoding>
> </configuration>
> </plugin>
> mvn clean resources:resources does result in a NPE:
> java.lang.NullPointerException
> at
> org.codehaus.plexus.interpolation.multi.DelimiterSpecification.parse(DelimiterSpecification.java:54)
> at
> org.codehaus.plexus.interpolation.multi.MultiDelimiterStringSearchInterpolator.setDelimiterSpecs(MultiDelimiterStringSearchInterpolator.java:394)
> ....
> Removing the ${*} it runs.
> However it breaks if "comments" are there in the property file. Using the
> defaultDelimiters this is no problem.
> Additionally its not possible to use the default ones and specify additional
> ones (maybe its a side effect and should work, don't know).
> The "$" gets ignored if i use
> <useDefaultDelimiters>true</useDefaultDelimiters> and
> <delimiter>$</delimiter> .
> Look at the attached project for an non working example. ${*} is commented in
> the pom, use it to get the NPE.
> Removing the first comment line from the property file does result in a
> successfull replacement (but comments are ok there so it should run with it
> too) - let the comment there and it does only replace the first occurence of
> the property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
