[ 
http://jira.codehaus.org/browse/MSHADE-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=189956#action_189956
 ] 

Mark Struberg edited comment on MSHADE-54 at 9/5/09 10:18 AM:
--------------------------------------------------------------

I did few tests first to figure out how the current behaviour is (all with 
shadedArtifactAttached=false for now)

fN-build: finalName in the <build> section
fN-shace: finalName in the <configuration> section of the shade plugin

{noformat}
fN-build=empty          
fN-shade=empty          
target  ='shaded'.jar + original-xx.jar 
repo    ='shaded'.jar


fN-build=MyBuildName    
fN-shade=empty          
target  =MyBuildName.jar + shaded with 'standard' artifact name
repo    =unshaded with 'standard' artifact name
                                

fN-build=MyBuildName    
fN-shade=OtherBuildName 
target  =MyBuildName.jar + shaded with OtherBuildName   
repo    =unshaded with 'standard' artifact name
                                

fN-build=MyBuildName    
fN-shade=MyBuildNamne   
target  =shaded "MyBuildName.jar" + "original-MyBuildName.jar"  
repo    =SHADED with 'standard' artifact name
                                

fN-build=empty          
fN-shade=MyBuildNamne   
target  =shaded "MyBuildName.jar" + UNshaded with 'standard' artifact name      
repo    =unshaded with 'standard' artifact name
{noformat}
(edit: format got mangled)

However, if I set shadedArtifactAttached=true the 
ShadeMojo#shadedArtifactFile(); and ShadeMojo#replaceFile(..) will not be 
called anyway. 

      was (Author: struberg):
    I did few tests first to figure out how the current behaviour is (all with 
shadedArtifactAttached=false for now)

fN-build: finalName in the <build> section
fN-shace: finalName in the <configuration> section of the shade plugin

{noformat}
fN-build fN-shade target repo
empty empty 'shaded'.jar + original-xx.jar 'shaded'.jar

MyBuildName empty MyBuildName.jar + shaded with unshaded with 'standard' 
artifact name
  'standard' artifact name

MyBuildName OtherBuildName MyBuildName.jar + shaded with unshaded with 
'standard' artifact name
  OtherBuildName

MyBuildName MyBuildNamne shaded "MyBuildName.jar" + SHADED with 'standard' 
artifact name
"original-MyBuildName.jar"

empty MyBuildNamne shaded "MyBuildName.jar" + unshaded with 'standard' artifact 
name
  UNshaded with 'standard'
artifact name
{noformat}


However, if I set shadedArtifactAttached=true the 
ShadeMojo#shadedArtifactFile(); and ShadeMojo#replaceFile(..) will not be 
called anyway. 
  
> <finalName> not respected when generating the package
> -----------------------------------------------------
>
>                 Key: MSHADE-54
>                 URL: http://jira.codehaus.org/browse/MSHADE-54
>             Project: Maven 2.x Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 1.2.1
>            Reporter: Sean McRae
>
> Specifying the final name of the package is not respected by the plugin, 
> instead the default name for the package is always used.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to