[
http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=182859#action_182859
]
Benjamin Bentmann commented on MWAR-164:
----------------------------------------
bq. Why do we have two strategies here (enconding specified in the xml and a
parameter for filtered resources).
XML files come with the luxus of an embedded encoding declaration and this
declaration has to be obeyed or interpolation fails, leaving the input either
unaltered or corrupted (it's a [fatal
error|http://www.w3.org/TR/REC-xml/#NT-EncodingDecl] if the encoding does not
match the file's byte stream). Most other resources files (i.e. non-XML
documents), are not equipped with an embedded encoding declaration so the user
has to provide the encoding in form of a parameter.
The Resources Plugin or better the filtering component should ideally be
enhanced to detect XML files and respect their encoding.
> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
> Key: MWAR-164
> URL: http://jira.codehaus.org/browse/MWAR-164
> Project: Maven 2.x WAR Plugin
> Issue Type: Improvement
> Affects Versions: 2.1-alpha-1
> Reporter: kai lilleby
> Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
