[
http://jira.codehaus.org/browse/MPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=144035#action_144035
]
Jürgen Hermann commented on MPH-40:
-----------------------------------
> We could make xml comments only if reactorProjects is empty.
Well, that'd help for a certain number of cases.
> If reactorProjects is not empty, the output file appends all effective poms
> in one file and thus it is an invalid xml file.
That can be solved by adding an outer root element around the POMs, which then
allows to select the needed POMs by standard tools (XPath) instead of trickery
that'll likely break in later releases. It certainly doesn't make automatic
processing any harder, just the opposite.
> help:effective-pom emits invalid XML to output file
> ---------------------------------------------------
>
> Key: MPH-40
> URL: http://jira.codehaus.org/browse/MPH-40
> Project: Maven 2.x Help Plugin
> Issue Type: Improvement
> Reporter: Jürgen Hermann
>
> Currently, this fragile post-processing is needed to make the content in a
> file generated with -Doutput=... parseable:
> <move overwrite="true" file="${deploy.effective.pom.xml.file}.tmp"
> tofile="${deploy.effective.pom.xml.file}">
> <filterchain>
> <replaceregex pattern="^(Created by:)"
> replace='<!-- \1' />
> <replaceregex pattern="^<.xml .*>(<project>)"
> replace='--> \1' />
> <replaceregex pattern="^\*+$" replace='' />
> </filterchain>
> </move>
> Solution: Either add XML comments in the generation markup, or only output
> the XML proper to the output file, leaving the text out of it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
