gnodet-bot commented on code in PR #14063:
URL: https://github.com/apache/maven/pull/14063#discussion_r4654860424
##########
impl/maven-impl/src/test/java/org/apache/maven/impl/model/profile/ConditionProfileActivatorTest.java:
##########
@@ -565,4 +566,18 @@ void testExecutableNegated() throws Exception {
assertActivation(false, newProfile("not(executable('neg-tool'))"),
newContext(null, sysProps));
assertActivation(true,
newProfile("not(executable('no-such-neg-tool'))"), newContext(null, sysProps));
}
+
+ @Test
+ void testExecutableWithCustomWindowsExtensionAndCombinedCondition() throws
Exception {
Review Comment:
⚠️ **Leftover `final`**: This new test method still uses `final var`. Remove
`final` to match the cleanup applied everywhere else in this PR.
```suggestion
var sysProps = Map.of(
```
##########
impl/maven-impl/src/test/java/org/apache/maven/impl/model/profile/ConditionProfileActivatorTest.java:
##########
@@ -565,4 +566,18 @@ void testExecutableNegated() throws Exception {
assertActivation(false, newProfile("not(executable('neg-tool'))"),
newContext(null, sysProps));
assertActivation(true,
newProfile("not(executable('no-such-neg-tool'))"), newContext(null, sysProps));
}
+
+ @Test
+ void testExecutableWithCustomWindowsExtensionAndCombinedCondition() throws
Exception {
+ Files.createFile(tempDir.resolve("docker.custom"));
+ final var sysProps = Map.of(
+ "env.PATH", tempDir.toString(),
+ "env.PATHEXT", ".CUSTOM",
Review Comment:
⚠️ **Leftover `final`**: Same issue — remove `final` here too.
```suggestion
var profile = newProfile("executable('docker') && ${enable.docker}
== 'true'");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]