slachiewicz opened a new pull request, #697:
URL: https://github.com/apache/maven-changes-plugin/pull/697
## What changed
- Replaced `org.apache.httpcomponents:httpclient:4.5.14` / `httpcore:4.4.16`
with `org.apache.httpcomponents.client5:httpclient5:5.6.5` and
`org.apache.httpcomponents.core5:httpcore5:5.5` (latest GA releases on Maven
Central).
- Updated `RestJiraDownloader` and `JiraHelper` to the HttpComponents 5.x
API:
- `org.apache.http.*` → `org.apache.hc.core5.http.*` /
`org.apache.hc.client5.http.*`
- classic `HttpGet`/`HttpPost`/`CloseableHttpResponse` now come from the
`classic` packages
- `getStatusLine().getStatusCode()` → `getCode()`; entity access via
`ClassicHttpResponse`
- request timeouts use `Timeout.ofMilliseconds(...)`;
`UsernamePasswordCredentials` takes `char[]`
- `ContentType.get(entity)` →
`ContentType.parseLenient(entity.getContentType())`
- `JiraHelper.getPidFromJira` now uses the 5.x
`HttpClient.execute(request, handler)` API
## Why
HttpComponents 4.x is end-of-life. This removes it from the plugin's compile
scope. (A 4.5.14/4.4.16 pair still appears in **test** scope only, pulled in
transitively by Maven Resolver's `maven-resolver-transport-http` test
dependency.)
## Verification
- `JAVA_HOME=…/17.0.20-amzn mvn -q -B -N spotless:check` — pass (after
`spotless:apply`)
- `mvn -q -B test` — 60 tests run, 0 failures, 0 errors, 1 skipped
- `mvn -B verify` — BUILD SUCCESS, same test totals
- `mvn dependency:tree` confirms `httpclient5:5.6.5` and `httpcore5:5.5` on
compile scope
## Risk
- No automated test exercises live JIRA HTTP traffic, so the 5.x
request/response behaviour is verified by compilation and API inspection only.
`httpcore5:5.5` is newer than the 5.4.4 that `httpclient5:5.6.5` was built
against; the two are binary compatible within the 5.x line, but a smoke test
against a real JIRA instance would be prudent before release.
- `JiraHelper.getPidFromJira` now closes the HTTP response automatically via
the response-handler API; previously the response was left open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]