slachiewicz opened a new pull request, #1287:
URL: https://github.com/apache/maven-plugin-tools/pull/1287

   Forward-port of #1286 to `master` (the Maven 4 line). Keep #1286 as the 
primary change; this PR is the sequential follow-up for the second active line.
   
   ## What changed
   
   - `maven-plugin-tools-api/pom.xml`: replace `httpclient` 4.5.14 / `httpcore` 
4.4.16 with `httpclient5` 5.6.1 and `httpcore5` 5.4.2.
   - `JavadocSite`: switch to the `org.apache.hc.client5.*` / 
`org.apache.hc.core5.*` APIs, keeping `master`'s existing plain `getUsername()` 
null/empty check (it does not use `StringUtils.isNotEmpty` there).
   
   ## Why
   
   `master` still declares the final HttpComponents 4.x releases in the same 
place and uses the same javadoc-site retrieval code, so it needs the same 
migration. This PR contains only the forward-port delta relative to `master`.
   
   ## Verification
   
   - `JAVA_HOME=.../17.0.20-amzn mvn -q -B -N spotless:check` — passed.
   - `JAVA_HOME=.../17.0.20-amzn mvn -q -B -pl maven-plugin-tools-api test` — 
61 tests, 0 failures, 0 errors, 0 skipped.
   
   ## Risk
   
   Same as #1286: no HttpComponents type is exposed in a public/protected 
signature, proxy credentials move to `char[]`, `AuthScope.ANY` is replaced by 
`new AuthScope(null, -1)`, and `HttpGet.reset()` replaces `releaseConnection()`.
   
   Draft pending CI and merge of #1286.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to