Sahil-Jaiswal-189 commented on PR #13945:
URL: https://github.com/apache/maven/pull/13945#issuecomment-6848030941

   @gnodet, Thanks for restoring the deprecated factory APIs. I have two 
questions about the intended level of backward compatibility:
   1. Request builders: Both builders previously exposed coordinateString(...), 
but now expose coordinatesString(...). Also, 
ArtifactCoordinatesFactoryRequest.ArtifactFactoryRequestBuilder was renamed, 
changing the return type of builder(). Should we preserve the old method names 
as deprecated aliases and retain the original builder type and return 
signature? Otherwise, existing code using those APIs can still break.
   2. Custom factory implementations: The deprecated create(request) methods 
now delegate to the new direct-parameter methods. This preserves old callers 
using Maven’s updated factories, but a custom factory implementing only the old 
request-based methods must still implement the new required methods. Is that 
migration intentional, or should unchanged custom implementations also remain 
supported?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to