[ 
http://jira.codehaus.org/browse/MNG-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126761
 ] 

Milos Kleint commented on MNG-3430:
-----------------------------------

the factory should use this constructor
protected DefaultToolchain( ToolchainModel model, String type, Logger logger )
for some reason the incomplete
protected DefaultToolchain( ToolchainModel model, Logger logger )
constructor is also present. 

What about I keep both constructors supported and the getType() method does 
this:
return type != null ? type : model.getType();




> Toolchain doesn't match Toolchain extensions
> --------------------------------------------
>
>                 Key: MNG-3430
>                 URL: http://jira.codehaus.org/browse/MNG-3430
>             Project: Maven 2
>          Issue Type: Bug
>    Affects Versions: 2.0.9
>            Reporter: Shane Isbell
>            Assignee: Milos Kleint
>            Priority: Minor
>
> Toolchain uses null key within storing toolchains in Maven Session, which 
> causes extensions not to match.
> Specifically, this problem occurs in the 
> DefaultToolchainManager.storeToolchainToBuildContext method.  When storing 
> into context
> context.put( getStorageKey( toolchain.getType() ), toolchain.getModel() );
> toolchain.getType() always returns null. Using toolchain.getModel().getType() 
> will return the correct type and fix the problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to