gnodet opened a new pull request, #13955:
URL: https://github.com/apache/maven/pull/13955

   ## Summary
   
   Replace the 386-line `FastTerminal` proxy with JLine 4.7.0's built-in 
`TerminalBuilder.buildDeferred()`, which provides the same semantics with less 
code and better performance.
   
   **Changes:**
   - **Delete `FastTerminal.java`** — replaced by JLine's `DeferredTerminal`
   - **Simplify `MessageUtils.systemInstall()`** — uses `buildDeferred()` + 
`onComplete()` callback
   - **Move `createTerminal()` to the first step of `doInvoke()`** — terminal 
builds in background while validate/pushProperties/configureLogging run
   - **Skip waiting on shutdown** — if the terminal isn't ready when the 
process exits, `close()` drains buffered output to stdout
   - **Bump JLine from 4.5.0 to 4.7.0**
   
   **Net: -390 lines** (+71, -461)
   
   ## Benchmark (JDK 25, macOS arm64)
   
   | | Wall clock |
   |---|---|
   | Maven 3.9.16 \`mvn -v\` | 0.478s |
   | Maven 4.0.0 (before) \`mvn -v\` | ~0.450s |
   | **Maven 4.0.0 (after) \`mvn -v\`** | **0.288s** |
   
   ## Test plan
   
   - [x] \`FastTerminalReentrancyTest\` updated to use \`DeferredTerminal\`
   - [x] \`MavenCliLoggingTest\` updated
   - [x] \`mvn -v\` prints output without waiting for terminal
   - [x] Real builds work normally with full terminal
   
   Depends on [jline/jline3#2430](https://github.com/jline/jline3/pull/2430) 
(released as JLine 4.7.0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to