gnodet commented on PR #12581:
URL: https://github.com/apache/maven/pull/12581#issuecomment-6778598219
I think we can split this cleanly:
**Permissions hardening**: the `permissions: {}` top-level lockdown +
explicit job-level grants is unambiguously good practice and everyone agrees on
it. This part should merge.
**SHA pinning of `maven-gh-actions-shared`**: I've reconsidered my earlier
position. The threat model for SHA pinning is a compromised third-party
maintainer silently moving a tag. Since we control
`apache/maven-gh-actions-shared`, that threat doesn't apply — if the shared
repo is compromised, the SHA pin provides no meaningful protection (the
attacker can just move the tag and open a Dependabot PR, or push directly to
the pinned branch). The only real gain is an audit trail for drift in the
shared workflows, which `@v5` with proper review policy on
`maven-gh-actions-shared` itself achieves equally well.
The maintenance cost is real: 100+ repos, Dependabot PRs for every commit to
the shared repo, and the risk of drift when repos fall behind (as shown by the
hash in this PR already being 8 commits stale at review time).
My suggestion: merge this PR with the permissions changes only, dropping the
SHA pins in favour of staying with `@v5`. That's consistent with the existing
ASF convention for internal shared workflows and avoids the governance debate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]