desruisseaux commented on code in PR #422:
URL: https://github.com/apache/maven-archiver/pull/422#discussion_r4511402879
##########
src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java:
##########
@@ -109,21 +95,12 @@ public class MavenArchiver {
"${artifact.groupIdPath}/${artifact.artifactId}/" +
"${artifact.baseVersion}/${artifact.artifactId}-"
+
"${artifact.baseVersion}${dashClassifier?}.${artifact.extension}";
- private static final List<String> ARTIFACT_EXPRESSION_PREFIXES;
-
private static final Pattern SPECIFICATION_VERSION_PATTERN =
Pattern.compile("([0-9]+\\.[0-9]+)(.*?)");
private static final Pattern NON_ALPHANUM =
Pattern.compile("[^A-Za-z0-9]");
private static final Pattern REPEATING_DOTS = Pattern.compile("\\.{2,}");
Review Comment:
Those two constants should be removed if the `cleanModuleName(String)`
alternative implementation is accepted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]