desruisseaux commented on PR #422:
URL: https://github.com/apache/maven-archiver/pull/422#issuecomment-6737743863

   A problem with the `ManifestConfiguration` class shared by all plugins 
having a `MANIFEST.MF` file is that it contains entries with no justification. 
For example `ManifestConfiguration` contains a `Package` entry which is not 
defined by the [JAR format 
specification](https://docs.oracle.com/en/java/javase/27/docs/specs/jar/jar.html)
 and the comment provides no explanation about the purpose of this attribute 
and which plugin needs it.
   
   Since the JAR plugin would be the only one to use Archiver 4 for now, I 
suggest a conservative approach with only the attribute relevant to the JAR 
plugin. Another example of configuration to omit would be `recompressAddedZips` 
(the code contains no explanation about this configuration neither).
   
   Then if some day another plugin wants to use this archiver, we should not 
put everything in `ManifestConfiguration`. We should check which entries are 
specific to JAR, which entries are specific to the other plugin, and put in 
`ManifestConfiguration` only the entries that are common to both.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to