slachiewicz opened a new pull request, #3579: URL: https://github.com/apache/maven-surefire/pull/3579
`surefire-shared-utils` keeps only the `logging` package of maven-shared-utils in the shaded jar; `cli`, `io`, `xml`, `StringUtils` and the rest are filtered out. After #3575, #3577 and #3578 nothing in Surefire's own code uses them, and `logging` references nothing else from the library, only JAnsi's `org.fusesource.jansi` classes, which Maven provides. Four tests that still reached the other shaded classes use the shaded commons-lang3 and commons-io instead; maven-shared-utils' `StringUtils.isEmpty` trims, so that call is now `isBlank`. Tests and ITs that use the real, unshaded maven-shared-utils dependency are unaffected. Verified: the shaded jar holds only `org/apache/maven/surefire/shared/utils/logging` from maven-shared-utils (8 classes); `mvn verify` on `surefire-api`, `surefire-extensions-api`, `surefire-booter`, `surefire-junit-platform` and `maven-surefire-common` → 239, 1, 175, 167 and 891 tests pass; of 16 ITs run locally (`CheckTestFailIfNoTestsForkCountIT` and `CheckTestNgGroupThreadParallelIT` with `forkCount=0`, `ConsoleOutputIT`, `JUnitPlatformIT`, `PlainOldJavaClasspathIT`), 15 pass and `ConsoleOutputIT.largerSoutThanMemory` ran Maven's own JVM out of heap on a 2-vCPU VM; the full suite is left to CI. Part of #3574. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
