simono commented on PR #435: URL: https://github.com/apache/maven-wrapper/pull/435#issuecomment-6741538597
Thanks for looking. I'd keep that separate from this fix, for two reasons: - Dropping the fallback is a breaking change for users who don't pin a checksum. Today, on images without `unzip` (e.g. `eclipse-temurin`, the environment from #425), `mvnw` works via `.tar.gz`. With unzip-only it would stop working there. #425 only breaks when `distributionSha256Sum` is set, and that's the case this PR handles. - The tar side is small: it's a single `tar xzf ... -C ...` call (only-mvnw L263), which GNU tar, bsdtar and busybox all support. This PR already validates the prerequisite early for the broken case: if `unzip` is missing and a checksum is pinned, it fails before downloading, with a message telling the user what to do, instead of failing the SHA-256 check against the wrong artifact. It's a minimal, non-breaking fix for #425 and doesn't stand in the way of going unzip-only later if you decide to. Could we get it merged as is? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
