slachiewicz opened a new pull request, #3581:
URL: https://github.com/apache/maven-surefire/pull/3581

   Removes `ProviderParameters.getDirectoryScanner()`, its 
`BaseProviderFactory` implementation, the `DirectoryScanner` interface and 
`DefaultDirectoryScanner`. Providers get their tests through `getScanResult()`, 
and nothing in Surefire called the old method; the only callers found in public 
code are unmaintained providers (see #3580), which can move to 
`getScanResult()` on their side. `FileScanner` moves back into 
`maven-surefire-common` as a package-private class, since the plugin is its 
only user, which keeps it off the forked JVM's class path. 
`DirectoryScannerParameters` stays: the plugin still passes includes and 
excludes to the forked JVM through it. The provider API page says the method 
has been removed.
   
   Verified: `mvn verify` on `surefire-api`, `surefire-extensions-api`, 
`surefire-booter`, `surefire-junit-platform` and `maven-surefire-common` → 230, 
1, 175, 167 and 891 tests pass; `CheckTestFailIfNoTestsForkCountIT`, 
`JUnitPlatformIT`, `PlainOldJavaClasspathIT` and `TestMethodPatternIT` pass (17 
ITs); the full `surefire-its` suite is left to CI.
   
   Closes #3580.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to