slachiewicz opened a new pull request, #3582:
URL: https://github.com/apache/maven-surefire/pull/3582

   `AbstractSurefireMojoTest` and `MojoMocklessTest` left directories behind in 
the system temp directory on every run. They created their includes files, fake 
jars and fake `classes` directories through `SureFireFileManager`, whose exit 
hook deletes only the files it created; a `classes` directory holding an 
`AnotherTest.class` cannot be deleted that way, so it stayed, and so did its 
`surefire-<user>` parent. All of these files are now created inside a JUnit 
`@TempDir`. `shouldExistTmpDirectory` has to create its directories in the real 
temp and build directories, since that is what it tests, and now deletes them 
in a `finally` block.
   
   Verified: `mvn install` (all unit tests, no ITs) with `java.io.tmpdir` 
pointed at an empty directory leaves 16 entries there on master and none with 
this change; all modules' tests pass.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to