gnodet-bot commented on code in PR #13881:
URL: https://github.com/apache/maven/pull/13881#discussion_r4502985437
##########
api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelParser.java:
##########
@@ -44,6 +48,17 @@
@Consumer
public interface ModelParser extends SpiService {
+ /**
+ * Returns a unique identifier for this parser, used in diagnostics when
multiple
+ * parsers fail or conflict. Must be globally unique across all extensions.
+ *
+ * @return the parser identifier, never {@code null}
+ */
Review Comment:
⚠️ **Missing `@since 4.2.0`:** `ModelParser` is `@since 4.0.0` but `id()` is
a new default method shipping first in 4.2.0. Apache Maven uses method-level
`@since` tags when new members are added to existing `@since 4.0.0` interfaces
(see e.g. `Session.buildInvocation()`).
```suggestion
* @return the parser identifier, never {@code null}
* @since 4.2.0
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
