gnodet-bot commented on code in PR #13881:
URL: https://github.com/apache/maven/pull/13881#discussion_r4501374833
##########
api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PropertyContributor.java:
##########
@@ -24,17 +24,20 @@
import org.apache.maven.api.ProtoSession;
import org.apache.maven.api.annotations.Consumer;
import org.apache.maven.api.annotations.Experimental;
-import org.apache.maven.api.di.Named;
/**
* Component able to contribute to Maven session user properties. This SPI
component is invoked
* very early, while there is no session created yet.
*
+ * <p>
+ * Implementations must be annotated with {@code @Named("my-unique-id")} on the
Review Comment:
💡 **Suggestion:** Use `{@link org.apache.maven.api.di.Named @Named}` instead
of `{@code @Named}` to give implementors IDE-navigable documentation and
implicitly communicate the package (since the `import` was just removed from
this interface):
```suggestion
* Implementations must be annotated with {@link
org.apache.maven.api.di.Named @Named}{@code ("my-unique-id")} on the
```
##########
api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelParser.java:
##########
@@ -37,13 +36,17 @@
* Note: to provide a Maven model "dialect" that supports symmetric
translation, implement
* {@link ModelDialectProvider}, which composes a pair of parser and writer.
*
+ * <p>
+ * Implementations must be annotated with {@code @Named("my-unique-id")} on the
Review Comment:
💡 **Suggestion:** Use `{@link org.apache.maven.api.di.Named @Named}` instead
of `{@code @Named}` to give implementors IDE-navigable documentation and
implicitly communicate the package (since the `import` was just removed from
this interface):
```suggestion
* Implementations must be annotated with {@link
org.apache.maven.api.di.Named @Named}{@code ("my-unique-id")} on the
```
##########
api/maven-api-spi/src/main/java/org/apache/maven/api/spi/SettingsParser.java:
##########
@@ -38,12 +37,15 @@
* Parsers must be available in the container building the settings. In
particular, a parser
* supplied by a core extension cannot read the bootstrap settings needed to
resolve that
* extension. This SPI does not change settings file discovery or extension
loading.
+ * <p>
+ * Implementations must be annotated with {@code @Named("my-unique-id")} on the
Review Comment:
💡 **Suggestion:** Use `{@link org.apache.maven.api.di.Named @Named}` instead
of `{@code @Named}` to give implementors IDE-navigable documentation and
implicitly communicate the package (since the `import` was just removed from
this interface):
```suggestion
* Implementations must be annotated with {@link
org.apache.maven.api.di.Named @Named}{@code ("my-unique-id")} on the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
