gnodet-bot commented on code in PR #2237: URL: https://github.com/apache/maven-resolver/pull/2237#discussion_r4388824263
########## src/site/markdown/transporter-known-issues.md: ########## @@ -66,6 +66,7 @@ you need to add `org.apache.maven.resolver.transport:transport-http-jetty` artif This situation is probably improving with Jetty 13 (which is supposed to be shipping with a native Java QUIC implementation). * When HTTP/3 is configured there is [no fallback to lower versions](https://github.com/jetty/jetty.project/issues/15423). The request will just time out. +* Jetty currently does not support configurable retries. Review Comment: The `Jetty` prefix is redundant — we're already under the `## The \`jetty\` … Transporter` heading, and no other bullet in this section names the transporter explicitly. Also, `currently` is temporal language that will go stale silently once Jetty adds retry support. Suggest aligning with the terse imperative style of the other bullets in this section: ```suggestion * Does not support configurable retries. ``` ########## src/site/markdown/transporter-known-issues.md: ########## @@ -93,3 +94,4 @@ artifact consumption scenarios, but it is not suitable for artifact deployment. * Does neither support HTTP/2 nor HTTP/3 * Supports only GET/HEAD, usable only for artifact consumption * Is and will never be present in Maven; is meant for applications integrating Resolver +* No configurable retries Review Comment: "No configurable retries" is a bare noun phrase, while every other bullet in this section uses a verb predicate: "Does neither support…", "Supports only…", "Is and will never be…". Also missing a trailing period. ```suggestion * Does not support configurable retries. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
