slachiewicz opened a new pull request, #1876: URL: https://github.com/apache/maven-mvnd/pull/1876
Fixes #1796 and #1284 on master: three tests that were skipped run again. - `EnvHelperTest#testCygwin` had a bare `@Disabled`. It called `toCygwin()`, which runs `cygpath` when one is on the PATH (Git for Windows ships one, printing `/c/work/tmp`), so it could only pass where `cygpath` is absent. The fallback conversion is now `EnvHelper.toCygdrive()` and the test checks that. - `SocketFamilyTest#testUnixFromTo` was disabled because the test framework did not see multi-release jars; master builds `common` for Java 17 without a version overlay, so it runs as is. - `ConcurrentDownloadsTest` was disabled because Mimir served the artifacts from its cache; it now passes `-Dmimir.enabled=false`, so the Camel and ActiveMQ distributions are downloaded again. On mvnd-1.x `SocketFamilyTest` keeps its documented `@Disabled` (the `java16` overlay is still there) and `ConcurrentDownloadsTest` already runs, since CI there puts Mimir in the project's `.mvn/extensions.xml`; the `testCygwin` fix follows in its own PR. Verified: `SocketFamilyTest` 5/5 and `EnvHelperTest` 3/3, none skipped; `ConcurrentDownloadsTest` passes (JVM mode, JDK 25, macOS); `spotless:check` passes --- - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
