gnodet-bot commented on code in PR #2226:
URL: https://github.com/apache/maven-resolver/pull/2226#discussion_r4371688942


##########
maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java:
##########
@@ -299,6 +299,8 @@ LocalRepositoryManager newLocalRepositoryManager(
      * to already carry any required authentication or proxy configuration. 
This method can be used to apply the
      * authentication/proxy configuration from a session to a bare repository 
definition to obtain the complete
      * repository definition for use in the resolution request.
+     * Repositories that already list mirrored repositories are not subjected 
to mirror selection again, while proxy
+     * and authentication selection still apply.

Review Comment:
   Nit: missing `<p>` paragraph separator before the new sentence — it runs 
directly into the previous paragraph body. Other Javadoc blocks in this file 
use `<p>` between paragraphs (see lines 63, 77).
   
   ```suggestion
        * <p>
        * Repositories that already list mirrored repositories are not 
subjected to mirror selection again, while proxy
        * and authentication selection still apply.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to