Copilot commented on code in PR #1734: URL: https://github.com/apache/maven-site/pull/1734#discussion_r4361597742
########## content/markdown/maven-jsr330.md: ########## @@ -210,7 +210,7 @@ See [Sisu's lifecycle support documentation](https://eclipse.dev/sisu/org.eclips [plexus]: https://codehaus-plexus.github.io/plexus-containers/ [plexus-component-metadata]: https://codehaus-plexus.github.io/plexus-containers/plexus-component-metadata/ [plexus-annotations]: https://codehaus-plexus.github.io/plexus-containers/plexus-component-annotations/ -[jsr330-plugin]: https://github.com/apache/maven-integration-testing/tree/master/core-it-suite/src/test/resources/mng-5382 +[jsr330-plugin]: https://github.com/apache/maven-integration-testing/tree/maven-3.10.x/core-it-suite/src/test/resources/mng-5382 Review Comment: Linking to a long-lived branch (`maven-3.10.x`) can be less stable than a permanent reference. If the intent is only to fix a 404 caused by default-branch changes, consider using the repository’s default branch (e.g., `main`) or pinning to a tag/commit for durability. ########## content/markdown/docs/4.0.0-rc-7/release-notes.md: ########## @@ -95,37 +95,37 @@ Maven 4.0.0-rc-7 continues gathering feedback before releasing Maven 4.0.0 GA. T - Fix #13084: sandbox profile activation context for external model builds ([#13158](https://github.com/apache/maven/pull/13158)) @gnodet - Fix: implement Node.getRepository() via local repository manager lookup ([#13159](https://github.com/apache/maven/pull/13159)) @gnodet - Fix #13100: honor repositories from legitimately-active external model profiles ([#13155](https://github.com/apache/maven/pull/13155)) @gnodet -- [[MNG-5146]](https://issues.apache.org/jira/browse/MNG-5146) - Fix parent relativePath mismatch check ([#13157](https://github.com/apache/maven/pull/13157)) @gnodet +- [\[MNG-5146\]](https://issues.apache.org/jira/browse/MNG-5146) - Fix parent relativePath mismatch check ([#13157](https://github.com/apache/maven/pull/13157)) @gnodet - Lower-case the OS family before matching it against the family names ([#13154](https://github.com/apache/maven/pull/13154)) @gnodet - Normalize lazy StAX parse failures in MavenXpp3Reader ([#13149](https://github.com/apache/maven/pull/13149)) @gnodet - Evaluate profile activation conditions lazily ([#13144](https://github.com/apache/maven/pull/13144)) @gnodet -- [[MNG-6979]](https://issues.apache.org/jira/browse/MNG-6979) - Initialize the current project from the execution root ([#13143](https://github.com/apache/maven/pull/13143)) @gnodet +- [\[MNG-6979\]](https://issues.apache.org/jira/browse/MNG-6979) - Initialize the current project from the execution root ([#13143](https://github.com/apache/maven/pull/13143)) @gnodet - Fix NPE on a recursive property reference in a list field ([#13145](https://github.com/apache/maven/pull/13145)) @gnodet -- [[MNG-6568]](https://issues.apache.org/jira/browse/MNG-6568) - Fix comparison cycles in version qualifiers ([#13113](https://github.com/apache/maven/pull/13113)) @gnodet -- [[MNG-8678]](https://issues.apache.org/jira/browse/MNG-8678) - Concurrent executor ignores java.lang.Error subclasses ([#13067](https://github.com/apache/maven/pull/13067)) @gnodet +- [\[MNG-6568\]](https://issues.apache.org/jira/browse/MNG-6568) - Fix comparison cycles in version qualifiers ([#13113](https://github.com/apache/maven/pull/13113)) @gnodet +- [\[MNG-8678\]](https://issues.apache.org/jira/browse/MNG-8678) - Concurrent executor ignores java.lang.Error subclasses ([#13067](https://github.com/apache/maven/pull/13067)) @gnodet Review Comment: If the goal is to avoid nested-bracket markdown parsing issues, escaping works but makes the source noisier across many entries. A cleaner alternative is to remove the inner brackets entirely and use link text like `MNG-5146` (i.e., `[MNG-5146](...)`) which avoids the parsing ambiguity while keeping the markdown easier to maintain. ########## content/markdown/docs/4.0.0-rc-7/release-notes.md: ########## @@ -95,37 +95,37 @@ Maven 4.0.0-rc-7 continues gathering feedback before releasing Maven 4.0.0 GA. T - Fix #13084: sandbox profile activation context for external model builds ([#13158](https://github.com/apache/maven/pull/13158)) @gnodet - Fix: implement Node.getRepository() via local repository manager lookup ([#13159](https://github.com/apache/maven/pull/13159)) @gnodet - Fix #13100: honor repositories from legitimately-active external model profiles ([#13155](https://github.com/apache/maven/pull/13155)) @gnodet -- [[MNG-5146]](https://issues.apache.org/jira/browse/MNG-5146) - Fix parent relativePath mismatch check ([#13157](https://github.com/apache/maven/pull/13157)) @gnodet +- [\[MNG-5146\]](https://issues.apache.org/jira/browse/MNG-5146) - Fix parent relativePath mismatch check ([#13157](https://github.com/apache/maven/pull/13157)) @gnodet Review Comment: If the goal is to avoid nested-bracket markdown parsing issues, escaping works but makes the source noisier across many entries. A cleaner alternative is to remove the inner brackets entirely and use link text like `MNG-5146` (i.e., `[MNG-5146](...)`) which avoids the parsing ambiguity while keeping the markdown easier to maintain. ########## content/markdown/scm.md: ########## @@ -208,8 +208,8 @@ The components in Git are shown in the following table. | Content | Repository | Mirror | Issues | |--------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------|-------------------------------------------------------------------------| | [Apache Maven Doxia base](doxia/) | [`https://gitbox.apache.org/repos/asf/maven-doxia.git`](https://gitbox.apache.org/repos/asf/maven-doxia.git) | [GitHub](https://github.com/apache/maven-doxia/) | [GitHub Issues](https://github.com/apache/maven-doxia/issues) | -| [Apache Maven Doxia Sitetools](doxia-sitetools/) | [`https://gitbox.apache.org/repos/asf/maven-doxia-sitetools.git`](https://gitbox.apache.org/repos/asf/maven-doxia-sitetools.git) | [GitHub](https://github.com/apache/maven-doxia-sitetools/) | [GitHub Issues](https://github.com/apache/maven-doxia-sitetools/issues) | -| [Apache Maven Doxia Converter](doxia-tools/doxia-converter/) | [`https://gitbox.apache.org/repos/asf/maven-doxia-converter.git`](https://gitbox.apache.org/repos/asf/maven-doxia-converter.git) | [GitHub](https://github.com/apache/maven-doxia-converter/) | [GitHub Issues](https://github.com/apache/maven-doxia-converter/issues) | +| [Apache Maven Doxia Sitetools](/doxia/doxia-sitetools/) | [`https://gitbox.apache.org/repos/asf/maven-doxia-sitetools.git`](https://gitbox.apache.org/repos/asf/maven-doxia-sitetools.git) | [GitHub](https://github.com/apache/maven-doxia-sitetools/) | [GitHub Issues](https://github.com/apache/maven-doxia-sitetools/issues) | +| [Apache Maven Doxia Converter](/doxia/doxia-tools/doxia-converter/) | [`https://gitbox.apache.org/repos/asf/maven-doxia-converter.git`](https://gitbox.apache.org/repos/asf/maven-doxia-converter.git) | [GitHub](https://github.com/apache/maven-doxia-converter/) | [GitHub Issues](https://github.com/apache/maven-doxia-converter/issues) | Review Comment: The updated links are absolute (start with `/`), while the preceding Doxia link is relative (`doxia/`). Absolute links will break if these docs are served under a non-root base path (common for versioned docs or preview deployments). Prefer consistent relative links here (e.g., `doxia/doxia-sitetools/` and `doxia/doxia-tools/doxia-converter/`) unless the site is guaranteed to be mounted at `/`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
