elharo commented on code in PR #565:
URL: https://github.com/apache/maven-ear-plugin/pull/565#discussion_r4359985050
##########
src/main/java/org/apache/maven/plugins/ear/AbstractEarModule.java:
##########
@@ -266,9 +267,10 @@ public String getBundleFileName() {
String outputFileNameMapping =
earExecutionContext.getOutputFileNameMapping();
bundleFileName =
MappingUtils.evaluateFileNameMapping(outputFileNameMapping, artifact);
} catch (InterpolationException e) {
- // We currently ignore this here, cause assumption is that
- // has already been happened before..
- // FIXME: Should be checked first.
+ Log log = earExecutionContext.getLog();
Review Comment:
I'm not sure this is right. I'm not sure this is wrong. But the FIXME seems
to indicate that logging is not the right response here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
