gnodet-bot commented on code in PR #2217:
URL: https://github.com/apache/maven-resolver/pull/2217#discussion_r4329625800
##########
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/filter/ruletree/PrefixTreeTest.java:
##########
@@ -33,10 +34,157 @@ public class PrefixTreeTest {
void smoke() {
PrefixTree prefixTree = new PrefixTree("root");
prefixTree.loadNodes(Stream.of("# comment", "", "/org/apache/maven"));
+ prefixTree.dump("");
+
+ assertFalse(prefixTree.acceptedPath("/com/google"));
+ assertFalse(prefixTree.acceptedPath("/com/google/maven/aaa"));
+
+ assertFalse(prefixTree.acceptedPath("/org/eclipse/maven"));
+ assertFalse(prefixTree.acceptedPath("/org/eclipse/maven/aaa"));
+
assertTrue(prefixTree.acceptedPath("/org/apache/maven"));
assertTrue(prefixTree.acceptedPath("/org/apache/maven/aaa"));
assertFalse(prefixTree.acceptedPath("/org/apache/baz"));
assertFalse(prefixTree.acceptedPath("/org/apache/baz/aaa"));
}
+
+ @Test
+ void overlappingShallow() {
+ PrefixTree prefixTree = new PrefixTree("root");
+ prefixTree.loadNodes(Stream.of("# comment", "/org", "/org/apache"));
+ prefixTree.dump("");
Review Comment:
🧹 Debug leftover: `dump()` prints to stdout during test runs. Remove before
merge.
```suggestion
```
##########
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/filter/ruletree/PrefixTreeTest.java:
##########
@@ -33,10 +34,157 @@ public class PrefixTreeTest {
void smoke() {
PrefixTree prefixTree = new PrefixTree("root");
prefixTree.loadNodes(Stream.of("# comment", "", "/org/apache/maven"));
+ prefixTree.dump("");
+
+ assertFalse(prefixTree.acceptedPath("/com/google"));
+ assertFalse(prefixTree.acceptedPath("/com/google/maven/aaa"));
+
+ assertFalse(prefixTree.acceptedPath("/org/eclipse/maven"));
+ assertFalse(prefixTree.acceptedPath("/org/eclipse/maven/aaa"));
+
assertTrue(prefixTree.acceptedPath("/org/apache/maven"));
assertTrue(prefixTree.acceptedPath("/org/apache/maven/aaa"));
assertFalse(prefixTree.acceptedPath("/org/apache/baz"));
assertFalse(prefixTree.acceptedPath("/org/apache/baz/aaa"));
}
+
+ @Test
+ void overlappingShallow() {
+ PrefixTree prefixTree = new PrefixTree("root");
+ prefixTree.loadNodes(Stream.of("# comment", "/org", "/org/apache"));
+ prefixTree.dump("");
+
+ assertFalse(prefixTree.acceptedPath("/com/google"));
+ assertFalse(prefixTree.acceptedPath("/com/google/maven/aaa"));
+
+ assertTrue(prefixTree.acceptedPath("/org/eclipse/maven"));
+ assertTrue(prefixTree.acceptedPath("/org/eclipse/maven/aaa"));
+
+ assertTrue(prefixTree.acceptedPath("/org/apache/maven"));
+ assertTrue(prefixTree.acceptedPath("/org/apache/maven/aaa"));
+
+ assertTrue(prefixTree.acceptedPath("/org/apache/baz"));
+ assertTrue(prefixTree.acceptedPath("/org/apache/baz/aaa"));
+ }
+
+ @Test
+ void overlappingDeep() {
+ PrefixTree prefixTree = new PrefixTree("root");
+ prefixTree.loadNodes(Stream.of("# comment", "", "/org/apache",
"/org/apache/maven"));
+ prefixTree.dump("");
Review Comment:
🧹 Debug leftover: `dump()` prints to stdout during test runs. Remove before
merge.
```suggestion
```
##########
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/filter/ruletree/PrefixTreeTest.java:
##########
@@ -33,10 +34,157 @@ public class PrefixTreeTest {
void smoke() {
PrefixTree prefixTree = new PrefixTree("root");
prefixTree.loadNodes(Stream.of("# comment", "", "/org/apache/maven"));
+ prefixTree.dump("");
Review Comment:
🧹 Debug leftover: `dump()` prints to stdout during test runs. Remove before
merge.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
