[ http://jira.codehaus.org/browse/DOXIA-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_124960 ]
Vincent Massol commented on DOXIA-204: -------------------------------------- The only issue is that we must have some well-known attributes so that sink implementations can be sure that they'll be available and putting them all in a map removes this notion of well-known attributes. My proposal was a bit different: * well-known attributes passed as method parameters as before * some extra optional attributes passed as SinkEventAttributes So sink implementation must support the well-known attributes while they can optionally support the extra optional ones. I'm not 100% happy with this either but we need a way to ensure that 1) parsers will use the correct attribute names and 2) sink impl. can rely on the existence of some well known attributes. > Add generic parameters support to Figure and Link events > -------------------------------------------------------- > > Key: DOXIA-204 > URL: http://jira.codehaus.org/browse/DOXIA-204 > Project: Maven Doxia > Issue Type: Improvement > Components: Sink API > Affects Versions: 1.0-alpha-10 > Reporter: Vincent Massol > Fix For: 1.0-beta-1 > > > For example XWiki has the following syntax for image macros and links: > * image: http://code.xwiki.org/xwiki/bin/view/Macros/ImageMacro > * links: http://platform.xwiki.org/xwiki/bin/view/Main/XWikiSyntax#HLinks > For the image macro there are the "document" and "fromincludingdoc" which are > specific to XWiki and thus cannot be put as standard parameters. > Same for links. > Thus I propose to allow parsers to pass a Map of properties (pair/values) to > the Sink API so that sinks can be written to understand them (the XWiki sink > would understand them for example). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira