gnodet-bot commented on code in PR #1815:
URL: https://github.com/apache/maven-resolver/pull/1815#discussion_r4255297679
##########
maven-resolver-util/src/test/java/org/eclipse/aether/util/graph/transformer/ConflictResolverTest.java:
##########
@@ -725,7 +805,7 @@ private static DependencyNode makeDependencyNode(String
groupId, String artifact
}
private static DependencyNode makeDependencyNode(String groupId, String
artifactId, String version, String scope) {
- return makeDependencyNode(groupId, artifactId, version, null,
"compile");
+ return makeDependencyNode(groupId, artifactId, version, null, scope);
Review Comment:
🐛 **Incidental bug fix** — this 4-arg `makeDependencyNode` overload was
previously hardcoding `"compile"` as the scope instead of forwarding the
`scope` parameter. This fix is correct and appreciated, but consider noting it
in the PR description or commit message since it's unrelated to the main
advised/enforced change.
##########
maven-resolver-util/src/test/java/org/eclipse/aether/util/graph/transformer/ConflictResolverTest.java:
##########
@@ -630,6 +672,28 @@ public boolean visitLeave(DependencyNode node) {
assertEquals(1, occurrenceOfSt3.get()); // st3 must be present only
once in tree
}
+ @ParameterizedTest
+ @MethodSource("conflictResolverSource")
+ void enforcedOptionalNotDerived(ConflictResolver conflictResolver) throws
RepositoryException {
Review Comment:
💡 **Minor coverage gap** — `enforcedOptionalNotDerived` verifies that
enforced optional is not derived from the parent. Consider adding a symmetric
`advisedOptionalIsDerived` test to verify that an _advised_ optional value
**is** correctly derived (inherited from a parent). This would make the test
coverage parallel between the two management modes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
