slachiewicz commented on PR #523: URL: https://github.com/apache/maven-dependency-plugin/pull/523#issuecomment-6024050451
Converted to draft: `prependGroupIdByDefault` is only ORed into `prependGroupId`, so it is a second switch for the same behaviour with the same default, and the question of why a new option is needed is still open. It also never reaches `DestFileFilter` in `getMarkedArtifactFilter()` (https://github.com/apache/maven-dependency-plugin/blob/master/src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java#L385-L397), so the overwrite check uses names without the groupId. What would make it ready: drop the new parameter and either fail the build on an actual overwrite or flip the `prependGroupId` default in a major, with an IT. Otherwise I'd close it; https://github.com/apache/maven-dependency-plugin/issues/1476 stays open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
