Tarun4201 commented on PR #13320:
URL: https://github.com/apache/maven/pull/13320#issuecomment-5953466007
Thanks for the thorough review! All points have been addressed in commit
`4f685c2`:
1. **Scope Manager & Dependency Manager Alignment**:
- `MavenSessionBuilderSupplier` now receives `usingMaven3CompatModel =
Features.maven3CompatModelVersion(mergedProps)` so that `ScopeManager` and
`DependencyManager` remain synchronized under `-Dsession.modelVersion=4.0.0`.
- Reused `usingMaven3CompatModel` at line 410 without redundant
recalculation.
2. **`@Config` Annotation on `MAVEN_SESSION_MODEL_VERSION`**:
- Updated to `@Config(source = Config.Source.USER_PROPERTIES)` and
removed `readOnly = true`, aligning with the property's intent as a
user-configurable property.
3. **Clarified Javadoc**:
- Narrowed `Features.maven3CompatModelVersion()` Javadoc to specifically
describe "resolver defaults" (scope manager configuration and dependency
manager transitivity).
4. **Restricted Mode Documentation**:
- Added an explanatory comment in `DefaultModelInterpolator` clarifying
why resolving `${session.modelVersion}` from `model.getModelVersion()` is safe
even when `restricted == true`, as it reads public metadata directly from the
model's XML.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
