gnodet-bot commented on code in PR #1149:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1149#discussion_r4166165417
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1300,13 +1300,6 @@ private void executeReal() throws
MojoExecutionException, CompilationFailureExce
}
Review Comment:
🔴 **Dead code:** With `patchJdkModuleVersion` removed,
`ModuleInfoTransformer.java` has zero callers — it's a package-private class
that is now unreachable dead code. It should be deleted in this PR to avoid
leaving orphaned artifacts behind.
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1300,13 +1300,6 @@ private void executeReal() throws
MojoExecutionException, CompilationFailureExce
}
Review Comment:
🔴 **Broken IT:** The `src/it/MCOMPILER-542/` integration test verifies the
exact behavior being removed here. Its `verify.groovy` asserts that:
- `module-info.class` contains the Java spec version (not the full JDK
version)
- Specific SHA-256/MD5 checksums match per JDK version
Without the patching, the JDK will write the full version string (e.g.
`21.0.10`) into `module-info.class`, and the checksum will change. Both
assertions will fail.
This IT needs to be either removed entirely or adapted to verify the new
(un-patched) behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
